diff options
| author | Michał Mirosław <mirq-linux@rere.qmqm.pl> | 2010-12-14 15:24:08 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-12-16 14:43:15 -0800 |
| commit | 0d0b16727f24f8258eeb33818347ca0f4557f982 (patch) | |
| tree | e89fec837700b02aff0d08de1c5cbae3ff5060a8 /drivers/net/niu.c | |
| parent | 55508d601dab7df5cbcc7a63f4be8620eface204 (diff) | |
| download | lwn-0d0b16727f24f8258eeb33818347ca0f4557f982.tar.gz lwn-0d0b16727f24f8258eeb33818347ca0f4557f982.zip | |
net: Fix drivers advertising HW_CSUM feature to use csum_start
Some drivers are using skb_transport_offset(skb) instead of skb->csum_start
for NETIF_F_HW_CSUM offload. This does not matter now, but if someone
implements checksumming of encapsulated packets then this will break silently.
TSO output paths are left as they are, since they are for IP+TCP only
(might be worth converting though).
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/niu.c')
| -rw-r--r-- | drivers/net/niu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/niu.c b/drivers/net/niu.c index f64c42414bd7..2541321bad82 100644 --- a/drivers/net/niu.c +++ b/drivers/net/niu.c @@ -6589,7 +6589,7 @@ static u64 niu_compute_tx_flags(struct sk_buff *skb, struct ethhdr *ehdr, (ip_proto == IPPROTO_UDP ? TXHDR_CSUM_UDP : TXHDR_CSUM_SCTP)); - start = skb_transport_offset(skb) - + start = skb_checksum_start_offset(skb) - (pad_bytes + sizeof(struct tx_pkt_hdr)); stuff = start + skb->csum_offset; |