diff options
| author | Amerigo Wang <amwang@redhat.com> | 2012-08-10 01:24:39 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-08-14 14:33:31 -0700 |
| commit | 3335f0ca130c201f8680e97f63612053fbc16e22 (patch) | |
| tree | 9e4b8cb06bd0d80be0ec6bd29f3e27ae63863f35 /drivers/net/netconsole.c | |
| parent | 38e6bc185d9544dfad1774b3f8902a0b061aea25 (diff) | |
| download | lwn-3335f0ca130c201f8680e97f63612053fbc16e22.tar.gz lwn-3335f0ca130c201f8680e97f63612053fbc16e22.zip | |
netconsole: do not release spin_lock when calling __netpoll_cleanup
With the previous patch applied, __netpoll_cleanup() is non-block now,
so we don't need to release the spin_lock before calling it.
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/netconsole.c')
| -rw-r--r-- | drivers/net/netconsole.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index f9347ea3d381..f0ad56c13933 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -640,12 +640,7 @@ static int netconsole_netdev_event(struct notifier_block *this, * rtnl_lock already held */ if (nt->np.dev) { - spin_unlock_irqrestore( - &target_list_lock, - flags); __netpoll_cleanup(&nt->np); - spin_lock_irqsave(&target_list_lock, - flags); dev_put(nt->np.dev); nt->np.dev = NULL; netconsole_target_put(nt); |