diff options
| author | Jeff Garzik <jeff@garzik.org> | 2007-07-17 00:01:09 -0400 |
|---|---|---|
| committer | Jeff Garzik <jeff@garzik.org> | 2007-07-17 16:17:59 -0400 |
| commit | f6c4286590e7cb13dd16cb2a6e4dc4a27ce6df1d (patch) | |
| tree | 92826825d123d0f0f52074024045cb43ec721cc5 /drivers/net/natsemi.c | |
| parent | 6f686d3d14621b90f3793b705bdf9fa624fd29ca (diff) | |
| download | lwn-f6c4286590e7cb13dd16cb2a6e4dc4a27ce6df1d.tar.gz lwn-f6c4286590e7cb13dd16cb2a6e4dc4a27ce6df1d.zip | |
[netdrvr] natsemi: Fix device removal bug
This episode illustrates how an overused warning can train people to
ignore that warning, which winds up hiding bugs.
The warning
drivers/net/natsemi.c: In function ‘natsemi_remove1’:
drivers/net/natsemi.c:3222: warning: ignoring return value of
‘device_create_file’, declared with attribute warn_unused_result
is oft-ignored, even though at close inspection one notices this occurs
in the /remove/ function, not normally where creation occurs. A quick
s/create/remove/ and we are fixed, with the warning gone.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net/natsemi.c')
| -rw-r--r-- | drivers/net/natsemi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c index 3450051ae56b..6bb48ba80964 100644 --- a/drivers/net/natsemi.c +++ b/drivers/net/natsemi.c @@ -671,7 +671,7 @@ static ssize_t natsemi_show_##_name(struct device *dev, \ #define NATSEMI_CREATE_FILE(_dev, _name) \ device_create_file(&_dev->dev, &dev_attr_##_name) #define NATSEMI_REMOVE_FILE(_dev, _name) \ - device_create_file(&_dev->dev, &dev_attr_##_name) + device_remove_file(&_dev->dev, &dev_attr_##_name) NATSEMI_ATTR(dspcfg_workaround); |