diff options
| author | Francesco Ruggeri <fruggeri@arista.com> | 2016-04-23 15:04:31 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-04-26 15:17:45 -0400 |
| commit | e96c37f185529d1db4ebc021e4f56822d43945bb (patch) | |
| tree | f2f4f5f2c66a81ba4505b8dc309ca7c30fe10d1b /drivers/net/macvtap.c | |
| parent | 308379607548524b8d86dbf20134681024935e0b (diff) | |
| download | lwn-e96c37f185529d1db4ebc021e4f56822d43945bb.tar.gz lwn-e96c37f185529d1db4ebc021e4f56822d43945bb.zip | |
macvtap: check minor when unregistering
macvtap_device_event(NETDEV_UNREGISTER) should check vlan->minor to
determine if it is being invoked in the context of a macvtap_newlink
that failed, for example in this code sequence:
macvtap_newlink
macvlan_common_newlink
register_netdevice
call_netdevice_notifiers(NETDEV_REGISTER, dev)
macvtap_device_event(NETDEV_REGISTER)
<fail here, vlan->minor = 0>
rollback_registered(dev);
rollback_registered_many
call_netdevice_notifiers(NETDEV_UNREGISTER, dev);
macvtap_device_event(NETDEV_UNREGISTER)
<nothing to clean up here>
Signed-off-by: Francesco Ruggeri <fruggeri@arista.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/macvtap.c')
| -rw-r--r-- | drivers/net/macvtap.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 95394edd1ed5..74cb15a2e032 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -1303,6 +1303,9 @@ static int macvtap_device_event(struct notifier_block *unused, } break; case NETDEV_UNREGISTER: + /* vlan->minor == 0 if NETDEV_REGISTER above failed */ + if (vlan->minor == 0) + break; devt = MKDEV(MAJOR(macvtap_major), vlan->minor); device_destroy(macvtap_class, devt); macvtap_free_minor(vlan); |