diff options
| author | Dongliang Mu <mudongliangabcd@gmail.com> | 2021-06-11 09:58:12 +0800 |
|---|---|---|
| committer | Stefan Schmidt <stefan@datenfreihafen.org> | 2021-06-14 12:42:20 +0200 |
| commit | ab372c2293f5d0b279f31c8d768566ea37602dc9 (patch) | |
| tree | 934f06d8ae1aa76ac09003a9135d24f8087d43be /drivers/net/ieee802154/mac802154_hwsim.c | |
| parent | f2386cf7c5f4ff5d7b584f5d92014edd7df6c676 (diff) | |
| download | lwn-ab372c2293f5d0b279f31c8d768566ea37602dc9.tar.gz lwn-ab372c2293f5d0b279f31c8d768566ea37602dc9.zip | |
ieee802154: hwsim: Fix possible memory leak in hwsim_subscribe_all_others
In hwsim_subscribe_all_others, the error handling code performs
incorrectly if the second hwsim_alloc_edge fails. When this issue occurs,
it goes to sub_fail, without cleaning the edges allocated before.
Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Acked-by: Alexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20210611015812.1626999-1-mudongliangabcd@gmail.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Diffstat (limited to 'drivers/net/ieee802154/mac802154_hwsim.c')
| -rw-r--r-- | drivers/net/ieee802154/mac802154_hwsim.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.c index da9135231c07..366eaae3550a 100644 --- a/drivers/net/ieee802154/mac802154_hwsim.c +++ b/drivers/net/ieee802154/mac802154_hwsim.c @@ -715,6 +715,8 @@ static int hwsim_subscribe_all_others(struct hwsim_phy *phy) return 0; +sub_fail: + hwsim_edge_unsubscribe_me(phy); me_fail: rcu_read_lock(); list_for_each_entry_rcu(e, &phy->edges, list) { @@ -722,8 +724,6 @@ me_fail: hwsim_free_edge(e); } rcu_read_unlock(); -sub_fail: - hwsim_edge_unsubscribe_me(phy); return -ENOMEM; } |