diff options
| author | Salva Peiró <speiro@ai2.upv.es> | 2013-12-17 10:06:30 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-01-15 15:31:36 -0800 |
| commit | e7834c71c2cacc621ddc64bd71f83ef2054f6539 (patch) | |
| tree | b5292140cd96af75e46c9a898529170f250761d0 /drivers/net/hamradio | |
| parent | 9ba6ad65b70f30b116660d6d74304d424248ff29 (diff) | |
| download | lwn-e7834c71c2cacc621ddc64bd71f83ef2054f6539.tar.gz lwn-e7834c71c2cacc621ddc64bd71f83ef2054f6539.zip | |
hamradio/yam: fix info leak in ioctl
[ Upstream commit 8e3fbf870481eb53b2d3a322d1fc395ad8b367ed ]
The yam_ioctl() code fails to initialise the cmd field
of the struct yamdrv_ioctl_cfg. Add an explicit memset(0)
before filling the structure to avoid the 4-byte info leak.
Signed-off-by: Salva Peiró <speiro@ai2.upv.es>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/hamradio')
| -rw-r--r-- | drivers/net/hamradio/yam.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c index 5af1c3e5032a..b7e967540509 100644 --- a/drivers/net/hamradio/yam.c +++ b/drivers/net/hamradio/yam.c @@ -1057,6 +1057,7 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) break; case SIOCYAMGCFG: + memset(&yi, 0, sizeof(yi)); yi.cfg.mask = 0xffffffff; yi.cfg.iobase = yp->iobase; yi.cfg.irq = yp->irq; |