diff options
| author | Bruno Carneiro da Cunha <brunocarneirodacunha@usp.br> | 2019-12-05 17:16:26 -0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-12-06 20:51:19 -0800 |
| commit | 04aa1bc42e4d31a7c58f38eefc323ac395517635 (patch) | |
| tree | 7ea4fe671733582122197606e02c78fa4ba04d06 /drivers/net/ethernet/nxp | |
| parent | 9424e2e7ad93ffffa88f882c9bc5023570904b55 (diff) | |
| download | lwn-04aa1bc42e4d31a7c58f38eefc323ac395517635.tar.gz lwn-04aa1bc42e4d31a7c58f38eefc323ac395517635.zip | |
lpc_eth: kernel BUG on remove
We may have found a bug in the nxp/lpc_eth.c driver. The function
platform_set_drvdata() is called twice, the second time it is called,
in lpc_mii_init(), it overwrites the struct net_device which should be
at pdev->dev->driver_data with pldat->mii_bus. When trying to remove
the driver, in lpc_eth_drv_remove(), platform_get_drvdata() will
return the pldat->mii_bus pointer and try to use it as a struct
net_device pointer. This causes unregister_netdev to segfault and
generate a kernel BUG. Is this reproducible?
Signed-off-by: Daniel Martinez <linux@danielsmartinez.com>
Signed-off-by: Bruno Carneiro da Cunha <brunocarneirodacunha@usp.br>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/nxp')
| -rw-r--r-- | drivers/net/ethernet/nxp/lpc_eth.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index ebb81d6d4ca1..656169214cdb 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c @@ -817,8 +817,6 @@ static int lpc_mii_init(struct netdata_local *pldat) pldat->mii_bus->priv = pldat; pldat->mii_bus->parent = &pldat->pdev->dev; - platform_set_drvdata(pldat->pdev, pldat->mii_bus); - node = of_get_child_by_name(pldat->pdev->dev.of_node, "mdio"); err = of_mdiobus_register(pldat->mii_bus, node); of_node_put(node); |