diff options
| author | Michal Schmidt <mschmidt@redhat.com> | 2023-10-19 09:13:46 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-10-20 11:45:07 +0100 |
| commit | 7db3111043885c146e795c199d39c3f9042d97c0 (patch) | |
| tree | b3f5a6e72fbbb2698b5cc1d94536f66e568dceb4 /drivers/net/ethernet/intel/i40e/i40e.h | |
| parent | f97eee484e71890131f9c563c5cc6d5a69e4308d (diff) | |
| download | lwn-7db3111043885c146e795c199d39c3f9042d97c0.tar.gz lwn-7db3111043885c146e795c199d39c3f9042d97c0.zip | |
iavf: initialize waitqueues before starting watchdog_task
It is not safe to initialize the waitqueues after queueing the
watchdog_task. It will be using them.
The chance of this causing a real problem is very small, because
there will be some sleeping before any of the waitqueues get used.
I got a crash only after inserting an artificial sleep in iavf_probe.
Queue the watchdog_task as the last step in iavf_probe. Add a comment to
prevent repeating the mistake.
Fixes: fe2647ab0c99 ("i40evf: prevent VF close returning before state transitions to DOWN")
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/intel/i40e/i40e.h')
0 files changed, 0 insertions, 0 deletions