diff options
| author | Bruce Allan <bruce.w.allan@intel.com> | 2013-01-05 05:08:31 +0000 |
|---|---|---|
| committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2013-01-27 02:08:19 -0800 |
| commit | 7dbbe5d5a5073d590790007d5b98d7fd51fd2ff5 (patch) | |
| tree | 106a553cf5852a094a2fd73cb65e3153d9de334f /drivers/net/ethernet/intel/e1000e/phy.c | |
| parent | 1f96012d34670202c135828482fffbf603b4dce0 (diff) | |
| download | lwn-7dbbe5d5a5073d590790007d5b98d7fd51fd2ff5.tar.gz lwn-7dbbe5d5a5073d590790007d5b98d7fd51fd2ff5.zip | |
e1000e: do not ignore variables which get set a value
Static analysis with cppcheck has shown a few instances of a variable which
is assigned a value that is never used. A number of these are the return
status of various driver function calls which should be passed back to the
caller of the current function.
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/e1000e/phy.c')
| -rw-r--r-- | drivers/net/ethernet/intel/e1000e/phy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/e1000e/phy.c b/drivers/net/ethernet/intel/e1000e/phy.c index 3b9712134409..b4aaf69f4410 100644 --- a/drivers/net/ethernet/intel/e1000e/phy.c +++ b/drivers/net/ethernet/intel/e1000e/phy.c @@ -3332,7 +3332,7 @@ s32 e1000_get_cable_length_82577(struct e1000_hw *hw) I82577_DSTATUS_CABLE_LENGTH_SHIFT; if (length == E1000_CABLE_LENGTH_UNDEFINED) - ret_val = -E1000_ERR_PHY; + return -E1000_ERR_PHY; phy->cable_length = length; |