diff options
| author | Eric Dumazet <edumazet@google.com> | 2017-01-18 19:44:42 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-01-19 11:49:15 -0500 |
| commit | 69fed99baac186013840ced3524562841296034f (patch) | |
| tree | 71bd26d5340acd4eec2f91be973fc093675a1a0a /drivers/net/ethernet/freescale/gianfar.c | |
| parent | 0dbd7ff3ac5017a46033a9d0a87a8267d69119d9 (diff) | |
| download | lwn-69fed99baac186013840ced3524562841296034f.tar.gz lwn-69fed99baac186013840ced3524562841296034f.zip | |
gianfar: Do not reuse pages from emergency reserve
A driver using dev_alloc_page() must not reuse a page that had to
use emergency memory reserve.
Otherwise all packets using this page will be immediately dropped,
unless for very specific sockets having SOCK_MEMALLOC bit set.
This issue might be hard to debug, because only a fraction of the RX
ring buffer would suffer from drops.
Fixes: 75354148ce69 ("gianfar: Add paged allocation and Rx S/G")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Claudiu Manoil <claudiu.manoil@freescale.com>
Acked-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/freescale/gianfar.c')
| -rw-r--r-- | drivers/net/ethernet/freescale/gianfar.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index a6e7afa878be..c1b671667920 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -2948,7 +2948,7 @@ static bool gfar_add_rx_frag(struct gfar_rx_buff *rxb, u32 lstatus, } /* try reuse page */ - if (unlikely(page_count(page) != 1)) + if (unlikely(page_count(page) != 1 || page_is_pfmemalloc(page))) return false; /* change offset to the other half */ |