summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/broadcom/bgmac.c
diff options
context:
space:
mode:
authorPeter Hurley <peter@hurleysoftware.com>2015-03-11 09:19:16 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-03-11 16:39:52 +0100
commit7fd6f640f2dd17dac6ddd6702c378cb0bb9cfa11 (patch)
treeb726c53178d24d15377206bcf25362d908b1420e /drivers/net/ethernet/broadcom/bgmac.c
parent9eccca0843205f87c00404b663188b88eb248051 (diff)
downloadlwn-7fd6f640f2dd17dac6ddd6702c378cb0bb9cfa11.tar.gz
lwn-7fd6f640f2dd17dac6ddd6702c378cb0bb9cfa11.zip
serial: 8250_dw: Fix deadlock in LCR workaround
Trying to write console output from within the serial console driver while the port->lock is held causes recursive deadlock: CPU 0 spin_lock_irqsave(&port->lock) printk() console_unlock() call_console_drivers() serial8250_console_write() spin_lock_irqsave(&port->lock) ** DEADLOCK ** The 8250_dw i/o accessors try to write a console error message if the LCR workaround was unsuccessful. When the port->lock is already held (eg., when called from serial8250_set_termios()), this deadlocks. Make the error message a FIXME until a general solution is devised. Cc: Tim Kryger <tim.kryger@gmail.com> Reported-by: Zhang Zhen <zhenzhang.zhang@huawei.com> Signed-off-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net/ethernet/broadcom/bgmac.c')
0 files changed, 0 insertions, 0 deletions