diff options
| author | Vivien Didelot <vivien.didelot@savoirfairelinux.com> | 2016-03-07 18:24:17 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-03-10 16:10:30 -0500 |
| commit | 2d9deae4aedee2be2205e22440ac357c37013658 (patch) | |
| tree | cd5f85c9f3b68b7cf376d25788575dabfbdaf6b6 /drivers/net/dsa/mv88e6xxx.h | |
| parent | 2a5a259f9757250dc786e2091759155a868179ae (diff) | |
| download | lwn-2d9deae4aedee2be2205e22440ac357c37013658.tar.gz lwn-2d9deae4aedee2be2205e22440ac357c37013658.zip | |
net: dsa: mv88e6xxx: rework port state setter
Apply a few non-functional changes on the port state setter:
* add a dynamic debug message with state names to track changes
* explicit states checking instead of assuming their numeric values
* lock mutex only once when changing several port states
* use bitmap macros to declare and access port_state_update_mask
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa/mv88e6xxx.h')
| -rw-r--r-- | drivers/net/dsa/mv88e6xxx.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/dsa/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx.h index d7b088dd8e16..3425616987ed 100644 --- a/drivers/net/dsa/mv88e6xxx.h +++ b/drivers/net/dsa/mv88e6xxx.h @@ -426,7 +426,7 @@ struct mv88e6xxx_priv_state { struct mv88e6xxx_priv_port ports[DSA_MAX_PORTS]; - unsigned long port_state_update_mask; + DECLARE_BITMAP(port_state_update_mask, DSA_MAX_PORTS); struct work_struct bridge_work; }; |