diff options
author | Andreea-Cristina Bernat <bernat.ada@gmail.com> | 2014-08-17 13:21:45 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-08-22 12:23:10 -0700 |
commit | b5091b552a9fd7c45f9f8f4efa23bc78af0553cd (patch) | |
tree | cd1d4b6718d78f478fbff4a5160896e936e74943 /drivers/net/bonding/bond_alb.c | |
parent | 270b4b3115d816a91fdb31a0c1686709eb60c3ed (diff) | |
download | lwn-b5091b552a9fd7c45f9f8f4efa23bc78af0553cd.tar.gz lwn-b5091b552a9fd7c45f9f8f4efa23bc78af0553cd.zip |
bonding: Replace rcu_dereference() with rcu_access_pointer()
This "rcu_dereference()" call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
"rcu_access_pointer()" instead of "rcu_dereference()".
Therefore, this patch makes this replacement.
The following Coccinelle semantic patch was used for solving it:
@@
@@
(
if(
(<+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+>)) {...}
|
while(
(<+...
- rcu_dereference
+ rcu_access_pointer
(...)
...+>)) {...}
)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding/bond_alb.c')
-rw-r--r-- | drivers/net/bonding/bond_alb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c index 95dd1f58c260..73c21e233131 100644 --- a/drivers/net/bonding/bond_alb.c +++ b/drivers/net/bonding/bond_alb.c @@ -1388,7 +1388,7 @@ static int bond_do_alb_xmit(struct sk_buff *skb, struct bonding *bond, } if (tx_slave && bond_slave_can_tx(tx_slave)) { - if (tx_slave != rcu_dereference(bond->curr_active_slave)) { + if (tx_slave != rcu_access_pointer(bond->curr_active_slave)) { ether_addr_copy(eth_data->h_source, tx_slave->dev->dev_addr); } |