diff options
| author | Sathya Perla <sathyap@serverengines.com> | 2009-08-10 03:43:23 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-08-12 22:13:17 -0700 |
| commit | cdab23b7017693c00dd69fa28bcdf5b0434b3838 (patch) | |
| tree | 2956d92941909e436bfaca87474025fadd519d1d /drivers/net/benet/be_main.c | |
| parent | a8e9179a7de196d37410fd3e9528081f22c70a4e (diff) | |
| download | lwn-cdab23b7017693c00dd69fa28bcdf5b0434b3838.tar.gz lwn-cdab23b7017693c00dd69fa28bcdf5b0434b3838.zip | |
be2net: fix bad queue traversal in be_rx_q_clean()
Using "for(tail != head)" to traverse a queue from tail to head
fails in the case of a fully filled queue. Use "for(used != 0)" instead.
Signed-off-by: Sathya Perla <sathyap@serverengines.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/benet/be_main.c')
| -rw-r--r-- | drivers/net/benet/be_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c index acce6a639324..9bbf447ee28f 100644 --- a/drivers/net/benet/be_main.c +++ b/drivers/net/benet/be_main.c @@ -1010,7 +1010,7 @@ static void be_rx_q_clean(struct be_adapter *adapter) /* Then free posted rx buffer that were not used */ tail = (rxq->head + rxq->len - atomic_read(&rxq->used)) % rxq->len; - for (; tail != rxq->head; index_inc(&tail, rxq->len)) { + for (; atomic_read(&rxq->used) > 0; index_inc(&tail, rxq->len)) { page_info = get_rx_page_info(adapter, tail); put_page(page_info->page); memset(page_info, 0, sizeof(*page_info)); |