diff options
| author | Jean Delvare <jdelvare@suse.de> | 2023-05-31 23:53:27 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-06-01 07:19:51 +0100 |
| commit | 5ccf40288ca0b4a0d000bee03829263a527cb46c (patch) | |
| tree | ba179938667a68e4037c92f7cf457dc5a8737a10 /drivers/mux | |
| parent | b866e7e7f995e14500d316a2e70977dee48cf690 (diff) | |
| download | lwn-5ccf40288ca0b4a0d000bee03829263a527cb46c.tar.gz lwn-5ccf40288ca0b4a0d000bee03829263a527cb46c.zip | |
mux: mmio: drop obsolete dependency on COMPILE_TEST
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.
It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.
As a minor optimization, this also lets us drop of_match_ptr(), as we
now know what it will resolve to, we might as well save cpp some work.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Peter Rosin <peda@axentia.se>
Link: https://lore.kernel.org/r/bc790b4e-1cb4-4ef5-3da8-9d0e6b613bc7@axentia.se
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/mux')
| -rw-r--r-- | drivers/mux/Kconfig | 2 | ||||
| -rw-r--r-- | drivers/mux/mmio.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig index e5c571fd232c..80f015cf6e54 100644 --- a/drivers/mux/Kconfig +++ b/drivers/mux/Kconfig @@ -47,7 +47,7 @@ config MUX_GPIO config MUX_MMIO tristate "MMIO/Regmap register bitfield-controlled Multiplexer" - depends on OF || COMPILE_TEST + depends on OF help MMIO/Regmap register bitfield-controlled Multiplexer controller. diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c index 44a7a0e885b8..245bc07eee4b 100644 --- a/drivers/mux/mmio.c +++ b/drivers/mux/mmio.c @@ -131,7 +131,7 @@ static int mux_mmio_probe(struct platform_device *pdev) static struct platform_driver mux_mmio_driver = { .driver = { .name = "mmio-mux", - .of_match_table = of_match_ptr(mux_mmio_dt_ids), + .of_match_table = mux_mmio_dt_ids, }, .probe = mux_mmio_probe, }; |