diff options
| author | David Woodhouse <dwmw2@infradead.org> | 2007-10-06 15:01:59 -0400 |
|---|---|---|
| committer | David Woodhouse <dwmw2@infradead.org> | 2007-10-06 15:01:59 -0400 |
| commit | 49defc015ff58fda46a3afa3462dfdfa69bc8401 (patch) | |
| tree | 992d7b968c1055a262b02c56dadb0ca1c65ab917 /drivers/mtd | |
| parent | 1fcf8ce51e7acc4b66904c4e159690c9467606b5 (diff) | |
| download | lwn-49defc015ff58fda46a3afa3462dfdfa69bc8401.tar.gz lwn-49defc015ff58fda46a3afa3462dfdfa69bc8401.zip | |
[MTD] [NAND] Avoid deadlock in erase callback; release chip lock first.
When the erase callback performs some other action on the flash, it's
highly likely to deadlock unless we actually release the chip lock
before calling it.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/nand/nand_base.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index d5691212058d..b4e0e7723894 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -2069,13 +2069,14 @@ int nand_erase_nand(struct mtd_info *mtd, struct erase_info *instr, erase_exit: ret = instr->state == MTD_ERASE_DONE ? 0 : -EIO; - /* Do call back function */ - if (!ret) - mtd_erase_callback(instr); /* Deselect and wake up anyone waiting on the device */ nand_release_device(mtd); + /* Do call back function */ + if (!ret) + mtd_erase_callback(instr); + /* * If BBT requires refresh and erase was successful, rewrite any * selected bad block tables |