diff options
| author | Samuel Tardieu <sam@rfc1149.net> | 2008-02-04 23:44:47 -0800 |
|---|---|---|
| committer | David Woodhouse <dwmw2@infradead.org> | 2008-02-07 10:34:36 +0000 |
| commit | 53fb84a0695ffeeeadf8ae92db28cbccf5325531 (patch) | |
| tree | d573cd02754704e0674821d759e39e9c7708eead /drivers/mtd/devices | |
| parent | d5476689afd48e71395602698409e9f48cbba413 (diff) | |
| download | lwn-53fb84a0695ffeeeadf8ae92db28cbccf5325531.tar.gz lwn-53fb84a0695ffeeeadf8ae92db28cbccf5325531.zip | |
[MTD] [DOC200x] eccbuf is statically defined and always evaluate to true
Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
Acked-by: Joern Engel <joern@logfs.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Diffstat (limited to 'drivers/mtd/devices')
| -rw-r--r-- | drivers/mtd/devices/doc2000.c | 4 | ||||
| -rw-r--r-- | drivers/mtd/devices/doc2001plus.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/mtd/devices/doc2000.c b/drivers/mtd/devices/doc2000.c index c73e96bfafc6..e9ce241b7fe5 100644 --- a/drivers/mtd/devices/doc2000.c +++ b/drivers/mtd/devices/doc2000.c @@ -632,7 +632,7 @@ static int doc_read(struct mtd_info *mtd, loff_t from, size_t len, len = ((from | 0x1ff) + 1) - from; /* The ECC will not be calculated correctly if less than 512 is read */ - if (len != 0x200 && eccbuf) + if (len != 0x200) printk(KERN_WARNING "ECC needs a full sector read (adr: %lx size %lx)\n", (long) from, (long) len); @@ -896,7 +896,7 @@ static int doc_write(struct mtd_info *mtd, loff_t to, size_t len, /* Let the caller know we completed it */ *retlen += len; - if (eccbuf) { + { unsigned char x[8]; size_t dummy; int ret; diff --git a/drivers/mtd/devices/doc2001plus.c b/drivers/mtd/devices/doc2001plus.c index 2b30b587c6e8..83be3461658f 100644 --- a/drivers/mtd/devices/doc2001plus.c +++ b/drivers/mtd/devices/doc2001plus.c @@ -748,7 +748,7 @@ static int doc_write(struct mtd_info *mtd, loff_t to, size_t len, WriteDOC(DoC_GetDataOffset(mtd, &fto), docptr, Mplus_FlashCmd); /* On interleaved devices the flags for 2nd half 512 are before data */ - if (eccbuf && before) + if (before) fto -= 2; /* issue the Serial Data In command to initial the Page Program process */ |