diff options
| author | Vasiliy Kovalev <kovalev@altlinux.org> | 2024-02-19 13:53:15 +0300 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2024-03-01 16:03:32 -0800 |
| commit | e606e4b71798cc1df20e987dde2468e9527bd376 (patch) | |
| tree | 78c401a13c5cf237a4993011f22bef471bef1054 /drivers/misc | |
| parent | f0b7f8ade9d2532a7d7da40eb297570d48dd2147 (diff) | |
| download | lwn-e606e4b71798cc1df20e987dde2468e9527bd376.tar.gz lwn-e606e4b71798cc1df20e987dde2468e9527bd376.zip | |
VMCI: Fix possible memcpy() run-time warning in vmci_datagram_invoke_guest_handler()
The changes are similar to those given in the commit 19b070fefd0d
("VMCI: Fix memcpy() run-time warning in dg_dispatch_as_host()").
Fix filling of the msg and msg_payload in dg_info struct, which prevents a
possible "detected field-spanning write" of memcpy warning that is issued
by the tracking mechanism __fortify_memcpy_chk.
Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
Link: https://lore.kernel.org/r/20240219105315.76955-1-kovalev@altlinux.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/vmw_vmci/vmci_datagram.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/misc/vmw_vmci/vmci_datagram.c b/drivers/misc/vmw_vmci/vmci_datagram.c index ba379cd6d054..3964d9e5a39b 100644 --- a/drivers/misc/vmw_vmci/vmci_datagram.c +++ b/drivers/misc/vmw_vmci/vmci_datagram.c @@ -378,7 +378,8 @@ int vmci_datagram_invoke_guest_handler(struct vmci_datagram *dg) dg_info->in_dg_host_queue = false; dg_info->entry = dst_entry; - memcpy(&dg_info->msg, dg, VMCI_DG_SIZE(dg)); + dg_info->msg = *dg; + memcpy(&dg_info->msg_payload, dg + 1, dg->payload_size); INIT_WORK(&dg_info->work, dg_delayed_dispatch); schedule_work(&dg_info->work); |