diff options
| author | Oded Gabbay <oded.gabbay@gmail.com> | 2019-02-28 10:46:14 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-02-28 13:04:59 +0100 |
| commit | 6765fda0f49df033f19aceb867678da7ca09f57a (patch) | |
| tree | 5d2da4ea281e7f6a7faffc944ff3926099b76213 /drivers/misc/habanalabs/goya/goya.c | |
| parent | 1e7c1ec14b03fa80783a6263084b2525c57592a1 (diff) | |
| download | lwn-6765fda0f49df033f19aceb867678da7ca09f57a.tar.gz lwn-6765fda0f49df033f19aceb867678da7ca09f57a.zip | |
habanalabs: fix validation of WREG32 to DMA completion
This patch fix a bug in the validation of WREG32 in DMA queues. The
validation was too strict. It allowed the user to set the completion
address only for DMA channel 1.
The fix allows the user to set the completion address for all 5 DMA
channels.
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/habanalabs/goya/goya.c')
| -rw-r--r-- | drivers/misc/habanalabs/goya/goya.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c index 5444cd0824b4..6f0075c4e935 100644 --- a/drivers/misc/habanalabs/goya/goya.c +++ b/drivers/misc/habanalabs/goya/goya.c @@ -3769,7 +3769,7 @@ static int goya_validate_wreg32(struct hl_device *hdev, dev_dbg(hdev->dev, "reg_offset == 0x%x\n", reg_offset); dev_dbg(hdev->dev, "value == 0x%x\n", wreg_pkt->value); - if (reg_offset != (mmDMA_CH_1_WR_COMP_ADDR_LO & 0xFFFF)) { + if (reg_offset != (mmDMA_CH_0_WR_COMP_ADDR_LO & 0x1FFF)) { dev_err(hdev->dev, "WREG32 packet with illegal address 0x%x\n", reg_offset); return -EPERM; |