diff options
| author | Takashi Iwai <tiwai@suse.de> | 2020-03-11 08:47:38 +0100 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2020-03-30 07:35:28 +0100 |
| commit | c2b5fdfba2a915b5001d3ec63f4b3fc651c22da4 (patch) | |
| tree | 434a90a43d526d2a2cfb16ee51cb711d894a3f2a /drivers/mfd | |
| parent | e3fadb35bc1be0078e9ff5f9a55811f7eb1a5d05 (diff) | |
| download | lwn-c2b5fdfba2a915b5001d3ec63f4b3fc651c22da4.tar.gz lwn-c2b5fdfba2a915b5001d3ec63f4b3fc651c22da4.zip | |
mfd: aat2870: Use scnprintf() for avoiding potential buffer overflow
There is still one call of sprintf() without checking the proper
buffer overflow in aat2870_dump_reg(). Replace it with scnprintf()
call for covering that.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd')
| -rw-r--r-- | drivers/mfd/aat2870-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/aat2870-core.c b/drivers/mfd/aat2870-core.c index 78ee4b28fca2..a17cf759739d 100644 --- a/drivers/mfd/aat2870-core.c +++ b/drivers/mfd/aat2870-core.c @@ -221,7 +221,7 @@ static ssize_t aat2870_dump_reg(struct aat2870_data *aat2870, char *buf) count += sprintf(buf, "aat2870 registers\n"); for (addr = 0; addr < AAT2870_REG_NUM; addr++) { - count += sprintf(buf + count, "0x%02x: ", addr); + count += snprintf(buf + count, PAGE_SIZE - count, "0x%02x: ", addr); if (count >= PAGE_SIZE - 1) break; |