diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-01-22 10:58:20 -0600 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2019-02-07 10:43:09 +0000 |
| commit | 9f208eca4f2faa38def458f663ec142a0b6f451b (patch) | |
| tree | fa891d17596b97766b5d0e8e2cd49ab3808233de /drivers/mfd/sm501.c | |
| parent | ae7b8eda27b33b1f688dfdebe4d46f690a8f9162 (diff) | |
| download | lwn-9f208eca4f2faa38def458f663ec142a0b6f451b.tar.gz lwn-9f208eca4f2faa38def458f663ec142a0b6f451b.zip | |
mfd: sm501: Use struct_size() in devm_kzalloc()
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:
struct foo {
int stuff;
struct boo entry[];
};
instance = devm_kzalloc(dev, sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:
instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/sm501.c')
| -rw-r--r-- | drivers/mfd/sm501.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index e0173bf4b0dc..d217debf382e 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -1142,8 +1142,7 @@ static int sm501_register_gpio_i2c_instance(struct sm501_devdata *sm, return -ENOMEM; /* Create a gpiod lookup using gpiochip-local offsets */ - lookup = devm_kzalloc(&pdev->dev, - sizeof(*lookup) + 3 * sizeof(struct gpiod_lookup), + lookup = devm_kzalloc(&pdev->dev, struct_size(lookup, table, 3), GFP_KERNEL); if (!lookup) return -ENOMEM; |