diff options
| author | Javier Martinez Canillas <javier@osg.samsung.com> | 2015-08-19 13:19:56 +0200 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2015-08-24 15:15:25 +0100 |
| commit | da935c0b6eeeac16de0a82cc1152fb0a9b5a11ef (patch) | |
| tree | 5f19b7424a4eba761005c1438563f9c37986cbd5 /drivers/mfd/Kconfig | |
| parent | 8de4efdaf3db897022fd20cc7b9168678417926c (diff) | |
| download | lwn-da935c0b6eeeac16de0a82cc1152fb0a9b5a11ef.tar.gz lwn-da935c0b6eeeac16de0a82cc1152fb0a9b5a11ef.zip | |
mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers
The ChromeOS EC SPI and I2C transport drivers depends on CROS_EC_PROTO
but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends
on is bad practice as it may lead to circular Kconfig dependencies.
Since these drivers already depend on MFD_CROS_EC and that config option
already selects CROS_EC_PROTO, there is no need to make them explicitly
depend on CROS_EC_PROTO since that dependency is already met.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/Kconfig')
| -rw-r--r-- | drivers/mfd/Kconfig | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 93837b4e8025..dd55c25fb656 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -105,7 +105,7 @@ config MFD_CROS_EC config MFD_CROS_EC_I2C tristate "ChromeOS Embedded Controller (I2C)" - depends on MFD_CROS_EC && CROS_EC_PROTO && I2C + depends on MFD_CROS_EC && I2C help If you say Y here, you get support for talking to the ChromeOS @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C config MFD_CROS_EC_SPI tristate "ChromeOS Embedded Controller (SPI)" - depends on MFD_CROS_EC && CROS_EC_PROTO && SPI + depends on MFD_CROS_EC && SPI ---help--- If you say Y here, you get support for talking to the ChromeOS EC |