summaryrefslogtreecommitdiff
path: root/drivers/memstick
diff options
context:
space:
mode:
authorNathan Chancellor <natechancellor@gmail.com>2020-11-12 13:07:02 -0700
committerHerbert Xu <herbert@gondor.apana.org.au>2020-11-20 14:45:32 +1100
commit5bdad829c31a09069fd508534f03c2ea1576ac75 (patch)
tree3bf721662ef8b4f542549b8116265ac0de5680f7 /drivers/memstick
parent0049a1329bb9569196a551bb658500394d98ed50 (diff)
downloadlwn-5bdad829c31a09069fd508534f03c2ea1576ac75.tar.gz
lwn-5bdad829c31a09069fd508534f03c2ea1576ac75.zip
crypto: crypto4xx - Replace bitwise OR with logical OR in crypto4xx_build_pd
Clang warns: drivers/crypto/amcc/crypto4xx_core.c:921:60: warning: operator '?:' has lower precedence than '|'; '|' will be evaluated first [-Wbitwise-conditional-parentheses] (crypto_tfm_alg_type(req->tfm) == CRYPTO_ALG_TYPE_AEAD) ? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ drivers/crypto/amcc/crypto4xx_core.c:921:60: note: place parentheses around the '|' expression to silence this warning (crypto_tfm_alg_type(req->tfm) == CRYPTO_ALG_TYPE_AEAD) ? ^ ) drivers/crypto/amcc/crypto4xx_core.c:921:60: note: place parentheses around the '?:' expression to evaluate it first (crypto_tfm_alg_type(req->tfm) == CRYPTO_ALG_TYPE_AEAD) ? ^ ( 1 warning generated. It looks like this should have been a logical OR so that PD_CTL_HASH_FINAL gets added to the w bitmask if crypto_tfm_alg_type is either CRYPTO_ALG_TYPE_AHASH or CRYPTO_ALG_TYPE_AEAD. Change the operator so that everything works properly. Fixes: 4b5b79998af6 ("crypto: crypto4xx - fix stalls under heavy load") Link: https://github.com/ClangBuiltLinux/linux/issues/1198 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Christian Lamparter <chunkeey@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'drivers/memstick')
0 files changed, 0 insertions, 0 deletions