diff options
| author | Andrzej Hajda <a.hajda@samsung.com> | 2015-09-24 11:00:18 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2015-10-03 11:32:32 -0300 |
| commit | e54560d963866a45e5905a16821e3904ed0c9561 (patch) | |
| tree | efc5204397e03f19ac48ebf4e388e84ea53bc028 /drivers/media/usb/cx231xx/cx231xx-video.c | |
| parent | 2788052a8ac9326723c8526f9c5953b8cfff8ab5 (diff) | |
| download | lwn-e54560d963866a45e5905a16821e3904ed0c9561.tar.gz lwn-e54560d963866a45e5905a16821e3904ed0c9561.zip | |
[media] cx231xx: fix handling cx231xx_read_i2c_data result
The function can return negative value.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/usb/cx231xx/cx231xx-video.c')
| -rw-r--r-- | drivers/media/usb/cx231xx/cx231xx-video.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/usb/cx231xx/cx231xx-video.c b/drivers/media/usb/cx231xx/cx231xx-video.c index 9798160698a3..d0d8f08e37c8 100644 --- a/drivers/media/usb/cx231xx/cx231xx-video.c +++ b/drivers/media/usb/cx231xx/cx231xx-video.c @@ -1114,7 +1114,8 @@ int cx231xx_enum_input(struct file *file, void *priv, struct cx231xx_fh *fh = priv; struct cx231xx *dev = fh->dev; u32 gen_stat; - unsigned int ret, n; + unsigned int n; + int ret; n = i->index; if (n >= MAX_CX231XX_INPUT) |