summaryrefslogtreecommitdiff
path: root/drivers/media/platform/nvidia
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>2025-08-10 04:29:52 +0300
committerHans Verkuil <hverkuil+cisco@kernel.org>2025-08-13 08:33:26 +0200
commit72517d9f76fe3b14a5f73ce5491e722c229a14bf (patch)
tree418c9662717ac07bf33d304ea3f164ed9e4595a0 /drivers/media/platform/nvidia
parent8003313d388f11cfcaaa88a731f113afda171887 (diff)
downloadlwn-72517d9f76fe3b14a5f73ce5491e722c229a14bf.tar.gz
lwn-72517d9f76fe3b14a5f73ce5491e722c229a14bf.zip
media: nvidia: tegra-vde: Replace file->private_data access
Accessing file->private_data manually to retrieve the v4l2_fh pointer is error-prone, as the field is a void * and will happily cast implicitly to any pointer type. The tegra-vde driver accesses file->private_data in the tegra_open() function, right after setting the field to &ctx->fh. Replace the accesses with usage of &ctx->fh. No functional change is intended, this only paves the way to remove direct accesses to file->private_data and make V4L2 drivers safer. Other accesses to the field will be addressed separately. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Diffstat (limited to 'drivers/media/platform/nvidia')
-rw-r--r--drivers/media/platform/nvidia/tegra-vde/v4l2.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/platform/nvidia/tegra-vde/v4l2.c b/drivers/media/platform/nvidia/tegra-vde/v4l2.c
index 531a85e3fe49..393dc3f07d5c 100644
--- a/drivers/media/platform/nvidia/tegra-vde/v4l2.c
+++ b/drivers/media/platform/nvidia/tegra-vde/v4l2.c
@@ -836,10 +836,10 @@ static int tegra_open(struct file *file)
v4l2_fh_add(&ctx->fh);
tegra_reset_coded_fmt(ctx);
- tegra_try_coded_fmt(file, file->private_data, &ctx->coded_fmt);
+ tegra_try_coded_fmt(file, &ctx->fh, &ctx->coded_fmt);
tegra_reset_decoded_fmt(ctx);
- tegra_try_decoded_fmt(file, file->private_data, &ctx->decoded_fmt);
+ tegra_try_decoded_fmt(file, &ctx->fh, &ctx->decoded_fmt);
return 0;