diff options
| author | NeilBrown <neilb@suse.de> | 2011-07-28 11:39:24 +1000 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2011-07-28 11:39:24 +1000 |
| commit | 8dbed5cebdf6796bf2618457b3653cf820934366 (patch) | |
| tree | b8e8421a3aae1ee8f21df97f76b116fd0a0a9b1c /drivers/md | |
| parent | 7399c31bc92a26bb8388a73f8e14acadcc512fe5 (diff) | |
| download | lwn-8dbed5cebdf6796bf2618457b3653cf820934366.tar.gz lwn-8dbed5cebdf6796bf2618457b3653cf820934366.zip | |
md/raid10 - avoid reading from known bad blocks - part 3
When attempting to repair a read error, don't read from
devices with a known bad block.
As we are only reading PAGE_SIZE blocks, we don't try to
narrow down to smaller regions in the hope that only part of this
page is bad - it isn't worth the effort.
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/raid10.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 37801d68a4cd..a5ecea2672b5 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1594,10 +1594,15 @@ static void fix_read_error(conf_t *conf, mddev_t *mddev, r10bio_t *r10_bio) rcu_read_lock(); do { + sector_t first_bad; + int bad_sectors; + d = r10_bio->devs[sl].devnum; rdev = rcu_dereference(conf->mirrors[d].rdev); if (rdev && - test_bit(In_sync, &rdev->flags)) { + test_bit(In_sync, &rdev->flags) && + is_badblock(rdev, r10_bio->devs[sl].addr + sect, s, + &first_bad, &bad_sectors) == 0) { atomic_inc(&rdev->nr_pending); rcu_read_unlock(); success = sync_page_io(rdev, |