diff options
| author | NeilBrown <neilb@suse.de> | 2013-04-24 11:42:42 +1000 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2013-04-24 11:42:42 +1000 |
| commit | c0b32972fb1e1110101702f096c0877afcab9f1d (patch) | |
| tree | 81f552bbd3db1a76b6c209e70bd0f141c3986bd4 /drivers/md/raid5.c | |
| parent | 6f608040ce6cf37475dd2f6f3c97b009dab7c1d1 (diff) | |
| download | lwn-c0b32972fb1e1110101702f096c0877afcab9f1d.tar.gz lwn-c0b32972fb1e1110101702f096c0877afcab9f1d.zip | |
md/raid5: avoid an extra write when writing to a known-bad-block.
If we write to a known-bad-block it will be flags as having
a ReadError by analyse_stripe, but the write will proceed anyway
(as it should). Then the read-error handling will kick in an
write again, then re-read.
We don't need that 'write-again', so set R5_ReWrite so it looks like
it has already been done. Then we will just get the re-read, which we
want.
Reported-by: majianpeng <majianpeng@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'drivers/md/raid5.c')
| -rw-r--r-- | drivers/md/raid5.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index f31882c1197a..4a7be455d6d8 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -1887,8 +1887,15 @@ static void raid5_end_write_request(struct bio *bi, int error) &rdev->mddev->recovery); } else if (is_badblock(rdev, sh->sector, STRIPE_SECTORS, - &first_bad, &bad_sectors)) + &first_bad, &bad_sectors)) { set_bit(R5_MadeGood, &sh->dev[i].flags); + if (test_bit(R5_ReadError, &sh->dev[i].flags)) + /* That was a successful write so make + * sure it looks like we already did + * a re-write. + */ + set_bit(R5_ReWrite, &sh->dev[i].flags); + } } rdev_dec_pending(rdev, conf->mddev); |