diff options
author | Yu Kuai <yukuai3@huawei.com> | 2023-05-29 21:11:02 +0800 |
---|---|---|
committer | Song Liu <song@kernel.org> | 2023-06-13 15:25:43 -0700 |
commit | 8295efbe68c080047e98d9c0eb5cb933b238a8cb (patch) | |
tree | 7442096e03bf560b894e7373e8cd04cd8136d98f /drivers/md/raid1.c | |
parent | 5ec6ca140a034682e421e2e808ef5ddfdfd65242 (diff) | |
download | lwn-8295efbe68c080047e98d9c0eb5cb933b238a8cb.tar.gz lwn-8295efbe68c080047e98d9c0eb5cb933b238a8cb.zip |
md/raid1-10: factor out a helper to submit normal write
There are multiple places to do the same thing, factor out a helper to
prevent redundant code, and the helper will be used in following patch
as well.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20230529131106.2123367-4-yukuai1@huaweicloud.com
Diffstat (limited to 'drivers/md/raid1.c')
-rw-r--r-- | drivers/md/raid1.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 92180f3a9f28..c6b2abb7d185 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -799,17 +799,8 @@ static void flush_bio_list(struct r1conf *conf, struct bio *bio) while (bio) { /* submit pending writes */ struct bio *next = bio->bi_next; - struct md_rdev *rdev = (void *)bio->bi_bdev; - bio->bi_next = NULL; - bio_set_dev(bio, rdev->bdev); - if (test_bit(Faulty, &rdev->flags)) { - bio_io_error(bio); - } else if (unlikely((bio_op(bio) == REQ_OP_DISCARD) && - !bdev_max_discard_sectors(bio->bi_bdev))) - /* Just ignore it */ - bio_endio(bio); - else - submit_bio_noacct(bio); + + raid1_submit_write(bio); bio = next; cond_resched(); } |