diff options
| author | NeilBrown <neilb@cse.unsw.edu.au> | 2005-09-09 16:23:50 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-09-09 16:39:11 -0700 |
| commit | 7b1e35f6d666693e8f376ce02242efca3ec09aaf (patch) | |
| tree | c471a526b69594ce1bd7daa44ab50c51a0c6bfcf /drivers/md/md.c | |
| parent | 3178b0dbdf67322f6506582e494bdf553cc85c32 (diff) | |
| download | lwn-7b1e35f6d666693e8f376ce02242efca3ec09aaf.tar.gz lwn-7b1e35f6d666693e8f376ce02242efca3ec09aaf.zip | |
[PATCH] md: allow hot-adding devices to arrays with non-persistant superblocks.
It is possibly (and occasionally useful) to have a raid1 without persistent
superblocks. The code in add_new_disk for adding a device to such an array
always tries to read a superblock.
This will obviously fail.
So do the appropriate test and call md_import_device with
appropriate args.
Signed-off-by: Neil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'drivers/md/md.c')
| -rw-r--r-- | drivers/md/md.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index f1ac356e656d..866c704e008a 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -2226,8 +2226,11 @@ static int add_new_disk(mddev_t * mddev, mdu_disk_info_t *info) mdname(mddev)); return -EINVAL; } - rdev = md_import_device(dev, mddev->major_version, - mddev->minor_version); + if (mddev->persistent) + rdev = md_import_device(dev, mddev->major_version, + mddev->minor_version); + else + rdev = md_import_device(dev, -1, -1); if (IS_ERR(rdev)) { printk(KERN_WARNING "md: md_import_device returned %ld\n", |