diff options
| author | Joe Thornber <ejt@redhat.com> | 2014-05-06 16:28:14 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-06-07 10:28:25 -0700 |
| commit | 36f7757dadcd45c0ecce396662f923c0841e12ff (patch) | |
| tree | 913003d6885b167a29da754c5a0b07b554a1b6fb /drivers/md/dm-thin.c | |
| parent | 4cf3d5e62ea1868a963f6430eb7e40e46ac7295b (diff) | |
| download | lwn-36f7757dadcd45c0ecce396662f923c0841e12ff.tar.gz lwn-36f7757dadcd45c0ecce396662f923c0841e12ff.zip | |
dm thin: allow metadata commit if pool is in PM_OUT_OF_DATA_SPACE mode
commit 8d07e8a5f5bc7b90f755d9b427ea930024f4c986 upstream.
Commit 3e1a0699 ("dm thin: fix out of data space handling") introduced
a regression in the metadata commit() method by returning an error if
the pool is in PM_OUT_OF_DATA_SPACE mode. This oversight caused a thin
device to return errors even if the default queue_if_no_space ENOSPC
handling mode is used.
Fix commit() to only fail if pool is in PM_READ_ONLY or PM_FAIL mode.
Reported-by: qindehua@163.com
Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/md/dm-thin.c')
| -rw-r--r-- | drivers/md/dm-thin.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c index 60cc50685c14..ec93a19d9122 100644 --- a/drivers/md/dm-thin.c +++ b/drivers/md/dm-thin.c @@ -920,7 +920,7 @@ static int commit(struct pool *pool) { int r; - if (get_pool_mode(pool) != PM_WRITE) + if (get_pool_mode(pool) >= PM_READ_ONLY) return -EINVAL; r = dm_pool_commit_metadata(pool->pmd); |