diff options
| author | Olaf Kirch <olaf.kirch@oracle.com> | 2007-05-09 02:32:52 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-09 12:30:46 -0700 |
| commit | 98221eb757de03d9aa6262b1eded2be708640ccc (patch) | |
| tree | cef3fd80f62d6227551adc75c34023d60cbaa9c1 /drivers/md/dm-crypt.c | |
| parent | 027581f3515b5ec2218847dab578afa439a9d6b9 (diff) | |
| download | lwn-98221eb757de03d9aa6262b1eded2be708640ccc.tar.gz lwn-98221eb757de03d9aa6262b1eded2be708640ccc.zip | |
dm crypt: fix avoid cloned bio ref after free
Do not access the bio after generic_make_request
We should never access a bio after generic_make_request - there's no guarantee
it still exists.
Signed-off-by: Olaf Kirch <olaf.kirch@oracle.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/md/dm-crypt.c')
| -rw-r--r-- | drivers/md/dm-crypt.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index db439363f97d..1dc2c62200ee 100644 --- a/drivers/md/dm-crypt.c +++ b/drivers/md/dm-crypt.c @@ -655,9 +655,12 @@ static void process_write(struct crypt_io *io) generic_make_request(clone); + /* Do not reference clone after this - it + * may be gone already. */ + /* out of memory -> run queues */ if (remaining) - congestion_wait(bio_data_dir(clone), HZ/100); + congestion_wait(WRITE, HZ/100); } } |