diff options
| author | Mike Snitzer <snitzer@kernel.org> | 2022-11-30 14:02:47 -0500 |
|---|---|---|
| committer | Mike Snitzer <snitzer@kernel.org> | 2022-12-01 11:43:41 -0500 |
| commit | 6b9973861cb2e96dcd0bb0f1baddc5c034207c5c (patch) | |
| tree | 000f275ee181f28052a58e10e2a5af1e0cbb2cd8 /drivers/md/dm-cache-target.c | |
| parent | 352b837a5541690d4f843819028cf2b8be83d424 (diff) | |
| download | lwn-6b9973861cb2e96dcd0bb0f1baddc5c034207c5c.tar.gz lwn-6b9973861cb2e96dcd0bb0f1baddc5c034207c5c.zip | |
dm cache: set needs_check flag after aborting metadata
Otherwise the commit that will be aborted will be associated with the
metadata objects that will be torn down. Must write needs_check flag
to metadata with a reset block manager.
Found through code-inspection (and compared against dm-thin.c).
Cc: stable@vger.kernel.org
Fixes: 028ae9f76f29 ("dm cache: add fail io mode and needs_check flag")
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Diffstat (limited to 'drivers/md/dm-cache-target.c')
| -rw-r--r-- | drivers/md/dm-cache-target.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c index 624a6335c832..5e92fac90b67 100644 --- a/drivers/md/dm-cache-target.c +++ b/drivers/md/dm-cache-target.c @@ -907,16 +907,16 @@ static void abort_transaction(struct cache *cache) if (get_cache_mode(cache) >= CM_READ_ONLY) return; - if (dm_cache_metadata_set_needs_check(cache->cmd)) { - DMERR("%s: failed to set 'needs_check' flag in metadata", dev_name); - set_cache_mode(cache, CM_FAIL); - } - DMERR_LIMIT("%s: aborting current metadata transaction", dev_name); if (dm_cache_metadata_abort(cache->cmd)) { DMERR("%s: failed to abort metadata transaction", dev_name); set_cache_mode(cache, CM_FAIL); } + + if (dm_cache_metadata_set_needs_check(cache->cmd)) { + DMERR("%s: failed to set 'needs_check' flag in metadata", dev_name); + set_cache_mode(cache, CM_FAIL); + } } static void metadata_operation_failed(struct cache *cache, const char *op, int r) |