diff options
| author | Coly Li <colyli@suse.de> | 2020-10-01 14:50:45 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-10-02 14:25:29 -0600 |
| commit | 17e4aed8309ff28670271546c2c3263eb12f5eb6 (patch) | |
| tree | 01a49fc3eea34328a4c364eee2aa4ce7a70c0230 /drivers/md/bcache/super.c | |
| parent | 84e5d1363cd8128820434cdb983ecab0f5c1b078 (diff) | |
| download | lwn-17e4aed8309ff28670271546c2c3263eb12f5eb6.tar.gz lwn-17e4aed8309ff28670271546c2c3263eb12f5eb6.zip | |
bcache: remove 'int n' from parameter list of bch_bucket_alloc_set()
The parameter 'int n' from bch_bucket_alloc_set() is not cleared
defined. From the code comments n is the number of buckets to alloc, but
from the code itself 'n' is the maximum cache to iterate. Indeed all the
locations where bch_bucket_alloc_set() is called, 'n' is alwasy 1.
This patch removes the confused and unnecessary 'int n' from parameter
list of bch_bucket_alloc_set(), and explicitly allocates only 1 bucket
for its caller.
Signed-off-by: Coly Li <colyli@suse.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md/bcache/super.c')
| -rw-r--r-- | drivers/md/bcache/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index d34495d27450..b4176b8e9571 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -486,7 +486,7 @@ static int __uuid_write(struct cache_set *c) closure_init_stack(&cl); lockdep_assert_held(&bch_register_lock); - if (bch_bucket_alloc_set(c, RESERVE_BTREE, &k.key, 1, true)) + if (bch_bucket_alloc_set(c, RESERVE_BTREE, &k.key, true)) return 1; size = meta_bucket_pages(&c->sb) * PAGE_SECTORS; |