diff options
| author | Coly Li <colyli@suse.de> | 2019-06-28 19:59:30 +0800 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2019-06-28 07:39:14 -0600 |
| commit | 08ec1e6282f271698f0053983fab89de6e1a8217 (patch) | |
| tree | c1b406c4b3772adf5808d8a18b443cf7317f1c4b /drivers/md/bcache/super.c | |
| parent | 578df99b1b0531d19af956530fe4da63d01a1604 (diff) | |
| download | lwn-08ec1e6282f271698f0053983fab89de6e1a8217.tar.gz lwn-08ec1e6282f271698f0053983fab89de6e1a8217.zip | |
bcache: add io error counting in write_bdev_super_endio()
When backing device super block is written by bch_write_bdev_super(),
the bio complete callback write_bdev_super_endio() simply ignores I/O
status. Indeed such write request also contribute to backing device
health status if the request failed.
This patch checkes bio->bi_status in write_bdev_super_endio(), if there
is error, bch_count_backing_io_errors() will be called to count an I/O
error to dc->io_errors.
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md/bcache/super.c')
| -rw-r--r-- | drivers/md/bcache/super.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index dc6702c2c4b6..73466bda12a7 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -197,7 +197,9 @@ err: static void write_bdev_super_endio(struct bio *bio) { struct cached_dev *dc = bio->bi_private; - /* XXX: error checking */ + + if (bio->bi_status) + bch_count_backing_io_errors(dc, bio); closure_put(&dc->sb_write); } |