diff options
| author | Paul Gortmaker <paul.gortmaker@windriver.com> | 2014-03-05 19:38:09 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-03-08 21:55:39 -0800 |
| commit | 0db03f3f0c3b8c95346e48a1a552132ca332fe8f (patch) | |
| tree | b7c479d283c483672ad862dbd9a4998e2409b12b /drivers/mcb | |
| parent | aa074c1c805a38c01c0dfe56f78d409e33be28a2 (diff) | |
| download | lwn-0db03f3f0c3b8c95346e48a1a552132ca332fe8f.tar.gz lwn-0db03f3f0c3b8c95346e48a1a552132ca332fe8f.zip | |
drivers/mcb: do not set default Kconfig variable to modular
Coverage builds found this build fail in ARM ebsa110_defconfig:
drivers/mcb/mcb-parse.c: In function 'chameleon_parse_cells':
drivers/mcb/mcb-parse.c:105:2: error: implicit declaration of function 'memcpy_fromio' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[2]: *** [drivers/mcb/mcb-parse.o] Error 1
A simple bisect will output this:
3764e82e5150d87b205c10cd78a9c9ab86fbfa51 is the first bad commit
commit 3764e82e5150d87b205c10cd78a9c9ab86fbfa51
Author: Johannes Thumshirn <johannes.thumshirn@men.de>
Date: Wed Feb 26 17:29:05 2014 +0100
drivers: Introduce MEN Chameleon Bus
The above commit used "default m" which is wrong. New drivers
should never be globally enabled with "default y/m". Whether
this driver makes sense to build on ARM is an independent issue.
Here we delete the "default m" line, which is the equivalent of
"default n".
Cc: Johannes Thumshirn <johannes.thumshirn@men.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/mcb')
| -rw-r--r-- | drivers/mcb/Kconfig | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/mcb/Kconfig b/drivers/mcb/Kconfig index b8f5d469165c..fe8252831c1c 100644 --- a/drivers/mcb/Kconfig +++ b/drivers/mcb/Kconfig @@ -4,7 +4,6 @@ menuconfig MCB tristate "MCB support" - default m help The MCB (MEN Chameleon Bus) is a Bus specific to MEN Mikroelektronik |