diff options
author | Geert Uytterhoeven <geert+renesas@glider.be> | 2019-10-21 16:23:09 +0200 |
---|---|---|
committer | Michael Ellerman <mpe@ellerman.id.au> | 2019-11-05 22:29:27 +1100 |
commit | 3b05a1e517e1a8cfda4866ec31d28b2bc4fee4c4 (patch) | |
tree | d200d724507722b1c5bf0aa7de17fe3db7dfe8b0 /drivers/macintosh/ans-lcd.c | |
parent | 16f6b67cf03cb43db7104acb2ca877bdc2606c92 (diff) | |
download | lwn-3b05a1e517e1a8cfda4866ec31d28b2bc4fee4c4.tar.gz lwn-3b05a1e517e1a8cfda4866ec31d28b2bc4fee4c4.zip |
powerpc/security: Fix debugfs data leak on 32-bit
"powerpc_security_features" is "unsigned long", i.e. 32-bit or 64-bit,
depending on the platform (PPC_FSL_BOOK3E or PPC_BOOK3S_64). Hence
casting its address to "u64 *", and calling debugfs_create_x64() is
wrong, and leaks 32-bit of nearby data to userspace on 32-bit platforms.
While all currently defined SEC_FTR_* security feature flags fit in
32-bit, they all have "ULL" suffixes to make them 64-bit constants.
Hence fix the leak by changing the type of "powerpc_security_features"
(and the parameter types of its accessors) to "u64". This also allows
to drop the cast.
Fixes: 398af571128fe75f ("powerpc/security: Show powerpc_security_features in debugfs")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20191021142309.28105-1-geert+renesas@glider.be
Diffstat (limited to 'drivers/macintosh/ans-lcd.c')
0 files changed, 0 insertions, 0 deletions