diff options
| author | Bastien Curutchet <bastien.curutchet@bootlin.com> | 2024-08-26 15:32:37 +0200 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2024-08-30 09:01:08 +0100 |
| commit | 2aad93b6de0d874038d3d7958be05011284cd6b9 (patch) | |
| tree | abf38223026fd74e4ce0c7708c5fcc0bf0a4c7e7 /drivers/leds | |
| parent | 045391a02bd971d431c83ad03f7cc51b6e2fe331 (diff) | |
| download | lwn-2aad93b6de0d874038d3d7958be05011284cd6b9.tar.gz lwn-2aad93b6de0d874038d3d7958be05011284cd6b9.zip | |
leds: pca9532: Remove irrelevant blink configuration error message
The update_hw_blink() function prints an error message when hardware is
not able to handle a blink configuration on its own. IMHO, this isn't a
'real' error since the software fallback is used afterwards.
Remove the error messages to avoid flooding the logs with unnecessary
messages.
Cc: stable@vger.kernel.org
Fixes: 48ca7f302cfc ("leds: pca9532: Use PWM1 for hardware blinking")
Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
Link: https://lore.kernel.org/r/20240826133237.134604-1-bastien.curutchet@bootlin.com
Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/leds-pca9532.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index 338ddada3de9..1b47acf54720 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -215,8 +215,7 @@ static int pca9532_update_hw_blink(struct pca9532_led *led, if (other->state == PCA9532_PWM1) { if (other->ldev.blink_delay_on != delay_on || other->ldev.blink_delay_off != delay_off) { - dev_err(&led->client->dev, - "HW can handle only one blink configuration at a time\n"); + /* HW can handle only one blink configuration at a time */ return -EINVAL; } } @@ -224,7 +223,7 @@ static int pca9532_update_hw_blink(struct pca9532_led *led, psc = ((delay_on + delay_off) * PCA9532_PWM_PERIOD_DIV - 1) / 1000; if (psc > U8_MAX) { - dev_err(&led->client->dev, "Blink period too long to be handled by hardware\n"); + /* Blink period too long to be handled by hardware */ return -EINVAL; } |