diff options
| author | Tom Rix <trix@redhat.com> | 2020-08-09 09:32:21 -0700 |
|---|---|---|
| committer | Pavel Machek <pavel@ucw.cz> | 2020-08-17 18:04:11 +0200 |
| commit | fa31311c31634e5e900d61b1eb24df4c8555b5f8 (patch) | |
| tree | 196daefe6767be1ea1f06aca672eb820ffe80b23 /drivers/leds/leds-mt6323.c | |
| parent | 2d26684a4af6d0829fa9ff637ff56160d571148f (diff) | |
| download | lwn-fa31311c31634e5e900d61b1eb24df4c8555b5f8.tar.gz lwn-fa31311c31634e5e900d61b1eb24df4c8555b5f8.zip | |
leds: mt6323: move period calculation
clang static analysis reports this problem
leds-mt6323.c:275:12: warning: Division by zero
duty_hw = MT6323_CAL_HW_DUTY(*delay_on, period);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is because period can be 0.
period = *delay_on + *delay_off;
There is a later check that *delay_on/off are valid.
if (!*delay_on && !*delay_off) {
*delay_on = 500;
*delay_off = 500;
}
Setting the delay_on/off means period needs to be recalculated
anyway. So move the period statements after this check.
Fixes: 216ec6cc4c19 ("leds: Add LED support for MT6323 PMIC")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Diffstat (limited to 'drivers/leds/leds-mt6323.c')
| -rw-r--r-- | drivers/leds/leds-mt6323.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds-mt6323.c index 2a13e3161bf4..7b240771e45b 100644 --- a/drivers/leds/leds-mt6323.c +++ b/drivers/leds/leds-mt6323.c @@ -249,15 +249,6 @@ static int mt6323_led_set_blink(struct led_classdev *cdev, int ret; /* - * Units are in ms, if over the hardware able - * to support, fallback into software blink - */ - period = *delay_on + *delay_off; - - if (period > MT6323_MAX_PERIOD) - return -EINVAL; - - /* * LED subsystem requires a default user * friendly blink pattern for the LED so using * 1Hz duty cycle 50% here if without specific @@ -269,6 +260,15 @@ static int mt6323_led_set_blink(struct led_classdev *cdev, } /* + * Units are in ms, if over the hardware able + * to support, fallback into software blink + */ + period = *delay_on + *delay_off; + + if (period > MT6323_MAX_PERIOD) + return -EINVAL; + + /* * Calculate duty_hw based on the percentage of period during * which the led is ON. */ |