diff options
| author | Wenwen Wang <wenwen@cs.uga.edu> | 2019-08-19 15:41:42 -0500 |
|---|---|---|
| committer | Jacek Anaszewski <jacek.anaszewski@gmail.com> | 2019-08-20 20:21:22 +0200 |
| commit | 60e2dde1e91ae0addb21ac380cc36ebee7534e49 (patch) | |
| tree | 211214d5b7dd4e43fd8352897fd20fdc0c6a2538 /drivers/leds/led-triggers.c | |
| parent | 3881a72f8d0657ca998b217d0a183974ea800401 (diff) | |
| download | lwn-60e2dde1e91ae0addb21ac380cc36ebee7534e49.tar.gz lwn-60e2dde1e91ae0addb21ac380cc36ebee7534e49.zip | |
led: triggers: Fix a memory leak bug
In led_trigger_set(), 'event' is allocated in kasprintf(). However, it is
not deallocated in the following execution if the label 'err_activate' or
'err_add_groups' is entered, leading to memory leaks. To fix this issue,
free 'event' before returning the error.
Fixes: 52c47742f79d ("leds: triggers: send uevent when changing triggers")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Diffstat (limited to 'drivers/leds/led-triggers.c')
| -rw-r--r-- | drivers/leds/led-triggers.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index 8d11a5e23227..eff1bda8b520 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -173,6 +173,7 @@ err_activate: list_del(&led_cdev->trig_list); write_unlock_irqrestore(&led_cdev->trigger->leddev_list_lock, flags); led_set_brightness(led_cdev, LED_OFF); + kfree(event); return ret; } |