diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-09-17 15:09:47 +0200 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2023-11-01 11:28:35 +0000 |
| commit | 6061302092305a0584aacf0d82a9d5e66653884c (patch) | |
| tree | 82e9d76907780600e6825ab75fc6ee4cbdcdb850 /drivers/leds/blink | |
| parent | eccc489ef68d70cfdd850ba24933f1febbf2893e (diff) | |
| download | lwn-6061302092305a0584aacf0d82a9d5e66653884c.tar.gz lwn-6061302092305a0584aacf0d82a9d5e66653884c.zip | |
leds: Convert all platform drivers to return void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().
All platform drivers below drivers/leds/ unconditionally return zero in
their remove callback and so can be converted trivially to the variant
returning void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230917130947.1122198-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'drivers/leds/blink')
| -rw-r--r-- | drivers/leds/blink/leds-lgm-sso.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lgm-sso.c index 35c61311e7fd..7b04ea146260 100644 --- a/drivers/leds/blink/leds-lgm-sso.c +++ b/drivers/leds/blink/leds-lgm-sso.c @@ -837,7 +837,7 @@ static int intel_sso_led_probe(struct platform_device *pdev) return 0; } -static int intel_sso_led_remove(struct platform_device *pdev) +static void intel_sso_led_remove(struct platform_device *pdev) { struct sso_led_priv *priv; struct sso_led *led, *n; @@ -850,8 +850,6 @@ static int intel_sso_led_remove(struct platform_device *pdev) } regmap_exit(priv->mmap); - - return 0; } static const struct of_device_id of_sso_led_match[] = { @@ -863,7 +861,7 @@ MODULE_DEVICE_TABLE(of, of_sso_led_match); static struct platform_driver intel_sso_led_driver = { .probe = intel_sso_led_probe, - .remove = intel_sso_led_remove, + .remove_new = intel_sso_led_remove, .driver = { .name = "lgm-ssoled", .of_match_table = of_sso_led_match, |