diff options
| author | Andy Shevchenko <andy.shevchenko@gmail.com> | 2021-05-29 14:19:29 +0300 |
|---|---|---|
| committer | Pavel Machek <pavel@ucw.cz> | 2021-08-03 23:46:12 +0200 |
| commit | 3dd34dfb09ae814922dd833cad11b215b238a1ba (patch) | |
| tree | 5094637924383f7faed0e4a2e85f279d19be8ecf /drivers/leds/blink | |
| parent | c31ef7004ee1fd417dd9448ba4a43f42090d27fe (diff) | |
| download | lwn-3dd34dfb09ae814922dd833cad11b215b238a1ba.tar.gz lwn-3dd34dfb09ae814922dd833cad11b215b238a1ba.zip | |
leds: lgm-sso: Convert to use list_for_each_entry*() API
Convert to use list_for_each_entry*() API insted of open coded variants.
It saves few lines of code and makes iteasier to read and maintain.
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Diffstat (limited to 'drivers/leds/blink')
| -rw-r--r-- | drivers/leds/blink/leds-lgm-sso.c | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lgm-sso.c index 5c012ffeeaa8..e47c47e421d6 100644 --- a/drivers/leds/blink/leds-lgm-sso.c +++ b/drivers/leds/blink/leds-lgm-sso.c @@ -621,7 +621,6 @@ __sso_led_dt_parse(struct sso_led_priv *priv, struct fwnode_handle *fw_ssoled) struct device *dev = priv->dev; struct sso_led_desc *desc; struct sso_led *led; - struct list_head *p; const char *tmp; u32 prop; int ret; @@ -707,10 +706,8 @@ __sso_led_dt_parse(struct sso_led_priv *priv, struct fwnode_handle *fw_ssoled) __dt_err: fwnode_handle_put(fwnode_child); /* unregister leds */ - list_for_each(p, &priv->led_list) { - led = list_entry(p, struct sso_led, list); + list_for_each_entry(led, &priv->led_list, list) sso_led_shutdown(led); - } return -EINVAL; } @@ -841,14 +838,12 @@ static int intel_sso_led_probe(struct platform_device *pdev) static int intel_sso_led_remove(struct platform_device *pdev) { struct sso_led_priv *priv; - struct list_head *pos, *n; - struct sso_led *led; + struct sso_led *led, *n; priv = platform_get_drvdata(pdev); - list_for_each_safe(pos, n, &priv->led_list) { - list_del(pos); - led = list_entry(pos, struct sso_led, list); + list_for_each_entry_safe(led, n, &priv->led_list, list) { + list_del(&led->list); sso_led_shutdown(led); } |