diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-07-27 10:39:06 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-26 21:20:52 -0700 |
| commit | 8c957d66d2edb3293ff6a45d660bdaec45f7a5d0 (patch) | |
| tree | f429a33e83beb4b926728cd72fb4e3a7a0fb22f3 /drivers/isdn | |
| parent | ff7b91262b3ad31dfe1461dace0314a773b0fa55 (diff) | |
| download | lwn-8c957d66d2edb3293ff6a45d660bdaec45f7a5d0.tar.gz lwn-8c957d66d2edb3293ff6a45d660bdaec45f7a5d0.zip | |
isdn: mISDN: hfcpci: Replace GFP_ATOMIC with GFP_KERNEL in hfc_probe()
hfc_probe() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/isdn')
| -rw-r--r-- | drivers/isdn/hardware/mISDN/hfcpci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/hardware/mISDN/hfcpci.c b/drivers/isdn/hardware/mISDN/hfcpci.c index 72a271b98873..ebb3fa2e1d00 100644 --- a/drivers/isdn/hardware/mISDN/hfcpci.c +++ b/drivers/isdn/hardware/mISDN/hfcpci.c @@ -2220,7 +2220,7 @@ hfc_probe(struct pci_dev *pdev, const struct pci_device_id *ent) struct hfc_pci *card; struct _hfc_map *m = (struct _hfc_map *)ent->driver_data; - card = kzalloc(sizeof(struct hfc_pci), GFP_ATOMIC); + card = kzalloc(sizeof(struct hfc_pci), GFP_KERNEL); if (!card) { printk(KERN_ERR "No kmem for HFC card\n"); return err; |