diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-03-11 11:14:43 +0300 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2016-03-11 10:06:55 +0100 |
| commit | 143d36a33b4d59a56bb8e913a17a105578fd3237 (patch) | |
| tree | 6bcdbecd1ea77ef89c7fb785575ba8e9b7b76064 /drivers/irqchip | |
| parent | edf8fcdc6b254236be005851af35ea5e826e7e09 (diff) | |
| download | lwn-143d36a33b4d59a56bb8e913a17a105578fd3237.tar.gz lwn-143d36a33b4d59a56bb8e913a17a105578fd3237.zip | |
irqchip/irq-alpine-msi: Release the correct domain on error
The "msi_domain" variable is NULL here so it leads to a NULL dereference. It
looks like we actually intended to free "middle_domain".
Fixes: e6b78f2c3e14 ('irqchip: Add the Alpine MSIX interrupt controller')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: kernel-janitors@vger.kernel.org
Cc: Tsahee Zidenberg <tsahee@annapurnalabs.com>
Link: http://lkml.kernel.org/r/20160311081442.GE31887@mwanda
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'drivers/irqchip')
| -rw-r--r-- | drivers/irqchip/irq-alpine-msi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c index f8712722a606..25384255b30f 100644 --- a/drivers/irqchip/irq-alpine-msi.c +++ b/drivers/irqchip/irq-alpine-msi.c @@ -220,7 +220,7 @@ static int alpine_msix_init_domains(struct alpine_msix_data *priv, middle_domain); if (!msi_domain) { pr_err("Failed to create MSI domain\n"); - irq_domain_remove(msi_domain); + irq_domain_remove(middle_domain); return -ENOMEM; } |