diff options
| author | Marc Zyngier <maz@kernel.org> | 2024-07-18 08:58:04 +0100 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2024-07-18 20:34:46 +0200 |
| commit | c9b4f313f6b83ac80e9d51845d092c32513efdb4 (patch) | |
| tree | bac4affbaf154d93b7d81293eb72f0d4d57aef4b /drivers/irqchip/irq-gic-v3-its-msi-parent.c | |
| parent | 99d7fbf8f813eb77dd4ec148c4596455910b2fa1 (diff) | |
| download | lwn-c9b4f313f6b83ac80e9d51845d092c32513efdb4.tar.gz lwn-c9b4f313f6b83ac80e9d51845d092c32513efdb4.zip | |
irqchip/gic-v3-its: Correctly fish out the DID for platform MSI
Similarly to PCI where msi-map/msi-mask are used to compute the full RID
(aka DID in ITS speak), use the msi-parent as the discovery mechanism,
since there is no way a device can generally express its ID.
However, since switching to a per-device MSI domain model, the domain
passed to its_pmsi_prepare() is the wrong one, and points to the device's
instead of the ITS'. Bad.
Use the parent domain instead, which is the ITS domain.
Fixes: 80b63cc1cc146 ("irqchip/gic-v3-its: Switch platform MSI to MSI parent")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240718075804.2245733-1-maz@kernel.org
Diffstat (limited to 'drivers/irqchip/irq-gic-v3-its-msi-parent.c')
| -rw-r--r-- | drivers/irqchip/irq-gic-v3-its-msi-parent.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-gic-v3-its-msi-parent.c b/drivers/irqchip/irq-gic-v3-its-msi-parent.c index 2f3fc597331b..e150365fbe89 100644 --- a/drivers/irqchip/irq-gic-v3-its-msi-parent.c +++ b/drivers/irqchip/irq-gic-v3-its-msi-parent.c @@ -134,7 +134,7 @@ static int its_pmsi_prepare(struct irq_domain *domain, struct device *dev, int ret; if (dev->of_node) - ret = of_pmsi_get_dev_id(domain, dev, &dev_id); + ret = of_pmsi_get_dev_id(domain->parent, dev, &dev_id); else ret = iort_pmsi_get_dev_id(dev, &dev_id); if (ret) |