diff options
| author | Jacob Pan <jacob.pan.linux@gmail.com> | 2020-09-25 09:32:44 -0700 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2020-10-01 14:52:46 +0200 |
| commit | 8d3bb3b8cbf2ffb3ef73720a48b3445518dcdb55 (patch) | |
| tree | 0128ef643c3e803b601e0665b73b2a818b717c53 /drivers/iommu/intel/svm.c | |
| parent | 1e6aaae93e9ddb9dc664993eb949b1da94cab3a5 (diff) | |
| download | lwn-8d3bb3b8cbf2ffb3ef73720a48b3445518dcdb55.tar.gz lwn-8d3bb3b8cbf2ffb3ef73720a48b3445518dcdb55.zip | |
iommu/uapi: Use named union for user data
IOMMU UAPI data size is filled by the user space which must be validated
by the kernel. To ensure backward compatibility, user data can only be
extended by either re-purpose padding bytes or extend the variable sized
union at the end. No size change is allowed before the union. Therefore,
the minimum size is the offset of the union.
To use offsetof() on the union, we must make it named.
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Link: https://lore.kernel.org/linux-iommu/20200611145518.0c2817d6@x1.home/
Link: https://lore.kernel.org/r/1601051567-54787-4-git-send-email-jacob.jun.pan@linux.intel.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'drivers/iommu/intel/svm.c')
| -rw-r--r-- | drivers/iommu/intel/svm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c index 95c3164a2302..99353d6468fa 100644 --- a/drivers/iommu/intel/svm.c +++ b/drivers/iommu/intel/svm.c @@ -370,7 +370,7 @@ int intel_svm_bind_gpasid(struct iommu_domain *domain, struct device *dev, spin_lock(&iommu->lock); ret = intel_pasid_setup_nested(iommu, dev, (pgd_t *)(uintptr_t)data->gpgd, - data->hpasid, &data->vtd, dmar_domain, + data->hpasid, &data->vendor.vtd, dmar_domain, data->addr_width); spin_unlock(&iommu->lock); if (ret) { |