diff options
| author | Alex Williamson <alex.williamson@redhat.com> | 2014-04-22 10:08:40 -0600 |
|---|---|---|
| committer | Joerg Roedel <joro@8bytes.org> | 2014-05-13 12:33:11 +0200 |
| commit | e028a9e6b8a637af09ac4114083280df4a7045f1 (patch) | |
| tree | 408a315bfb5d3e2b227363c2c6acc44a8027355d /drivers/iommu/amd_iommu.c | |
| parent | d6d211db37e75de2ddc3a4f979038c40df7cc79c (diff) | |
| download | lwn-e028a9e6b8a637af09ac4114083280df4a7045f1.tar.gz lwn-e028a9e6b8a637af09ac4114083280df4a7045f1.zip | |
iommu/amd: Fix interrupt remapping for aliased devices
An apparent cut and paste error prevents the correct flags from being
set on the alias device resulting in MSI on conventional PCI devices
failing to work. This also produces error events from the IOMMU like:
AMD-Vi: Event logged [INVALID_DEVICE_REQUEST device=00:14.4 address=0x000000fdf8000000 flags=0x0a00]
Where 14.4 is a PCIe-to-PCI bridge with a device behind it trying to
use MSI interrupts.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Joerg Roedel <joro@8bytes.org>
Diffstat (limited to 'drivers/iommu/amd_iommu.c')
| -rw-r--r-- | drivers/iommu/amd_iommu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index c949520bd196..57068e8035b5 100644 --- a/drivers/iommu/amd_iommu.c +++ b/drivers/iommu/amd_iommu.c @@ -3999,7 +3999,7 @@ static struct irq_remap_table *get_irq_table(u16 devid, bool ioapic) iommu_flush_dte(iommu, devid); if (devid != alias) { irq_lookup_table[alias] = table; - set_dte_irq_entry(devid, table); + set_dte_irq_entry(alias, table); iommu_flush_dte(iommu, alias); } |