diff options
| author | Yang Li <yang.lee@linux.alibaba.com> | 2022-06-28 22:49:08 -0700 |
|---|---|---|
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2022-06-28 22:50:48 -0700 |
| commit | b2274ff2c4bb7eb6fca6039c7e431506c6c26605 (patch) | |
| tree | 8c8f81c5988e005fa7b369f4b9a94290a7bfa5a5 /drivers/input/joystick | |
| parent | 6bb7144c3fa16a5efb54a8e2aff1817b4168018e (diff) | |
| download | lwn-b2274ff2c4bb7eb6fca6039c7e431506c6c26605.tar.gz lwn-b2274ff2c4bb7eb6fca6039c7e431506c6c26605.zip | |
Input: sensehat-joystick - remove unnecessary error message
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
Eliminates the follow coccicheck warning:
./drivers/input/joystick/sensehat-joystick.c:102:2-9: line 102 is redundant because platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/20220427004906.129893-1-yang.lee@linux.alibaba.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/joystick')
| -rw-r--r-- | drivers/input/joystick/sensehat-joystick.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/input/joystick/sensehat-joystick.c b/drivers/input/joystick/sensehat-joystick.c index 5ad1fe4ff496..a84df39d3b2f 100644 --- a/drivers/input/joystick/sensehat-joystick.c +++ b/drivers/input/joystick/sensehat-joystick.c @@ -98,10 +98,8 @@ static int sensehat_joystick_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "Could not retrieve interrupt request"); + if (irq < 0) return irq; - } error = devm_request_threaded_irq(&pdev->dev, irq, NULL, sensehat_joystick_report, |