diff options
| author | Easwar Hariharan <easwar.hariharan@intel.com> | 2016-08-16 13:25:34 -0700 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2016-08-22 15:00:42 -0400 |
| commit | f29a08dc145e05de6a57f0aeaba6020464f80e15 (patch) | |
| tree | 775ef2974f0e86c9e78f6ea7ad6f2771b891ffc0 /drivers/infiniband | |
| parent | 701b4bf6e3eeff1a856d6889e1ebb35edd6c019a (diff) | |
| download | lwn-f29a08dc145e05de6a57f0aeaba6020464f80e15.tar.gz lwn-f29a08dc145e05de6a57f0aeaba6020464f80e15.zip | |
IB/hfi1: Return invalid field for non-QSFP CableInfo queries
The driver does not check if the CableInfo query is supported for the
port type. Return early if CableInfo is not supported for the port type,
making compliance with the specification explicit and preventing lower
level code from potentially doing the wrong thing if the query is not
supported for the hardware implementation.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Easwar Hariharan <easwar.hariharan@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/hw/hfi1/mad.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/infiniband/hw/hfi1/mad.c b/drivers/infiniband/hw/hfi1/mad.c index 95c43e1e0ce5..39e42c373a01 100644 --- a/drivers/infiniband/hw/hfi1/mad.c +++ b/drivers/infiniband/hw/hfi1/mad.c @@ -1819,6 +1819,11 @@ static int __subn_get_opa_cable_info(struct opa_smp *smp, u32 am, u8 *data, u32 len = OPA_AM_CI_LEN(am) + 1; int ret; + if (dd->pport->port_type != PORT_TYPE_QSFP) { + smp->status |= IB_SMP_INVALID_FIELD; + return reply((struct ib_mad_hdr *)smp); + } + #define __CI_PAGE_SIZE BIT(7) /* 128 bytes */ #define __CI_PAGE_MASK ~(__CI_PAGE_SIZE - 1) #define __CI_PAGE_NUM(a) ((a) & __CI_PAGE_MASK) |