diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-05-15 17:59:28 +0200 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2022-06-11 14:35:27 +0100 |
| commit | ab91da2f25746c2c30117d9ce93a7960ccd2f2cf (patch) | |
| tree | d8287ee9447bcf874961581ee3235d9efe10c9c2 /drivers/iio/light | |
| parent | 5049646718d768caebc503a654d0e5f8950ddd14 (diff) | |
| download | lwn-ab91da2f25746c2c30117d9ce93a7960ccd2f2cf.tar.gz lwn-ab91da2f25746c2c30117d9ce93a7960ccd2f2cf.zip | |
iio:light:vcnl4000: Improve error reporting for problems during .remove()
Returning an error value in an i2c remove callback results in a generic
error message being emitted by the i2c core, but otherwise it doesn't
make a difference. The device goes away anyhow and the devm cleanups are
called.
So instead of triggering the generic i2c error message, emit a more
helpful message if a problem occurs and return 0 to suppress the generic
message.
This patch is a preparation for making i2c remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220515155929.338656-8-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/light')
| -rw-r--r-- | drivers/iio/light/vcnl4000.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index e02e92bc2928..947a41b86173 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -1115,13 +1115,19 @@ static int vcnl4000_remove(struct i2c_client *client) { struct iio_dev *indio_dev = i2c_get_clientdata(client); struct vcnl4000_data *data = iio_priv(indio_dev); + int ret; pm_runtime_dont_use_autosuspend(&client->dev); pm_runtime_disable(&client->dev); iio_device_unregister(indio_dev); pm_runtime_set_suspended(&client->dev); - return data->chip_spec->set_power_state(data, false); + ret = data->chip_spec->set_power_state(data, false); + if (ret) + dev_warn(&client->dev, "Failed to power down (%pe)\n", + ERR_PTR(ret)); + + return 0; } static int __maybe_unused vcnl4000_runtime_suspend(struct device *dev) |