diff options
| author | Chen Zhongjin <chenzhongjin@huawei.com> | 2022-11-08 11:28:02 +0800 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2022-11-12 17:53:35 +0000 |
| commit | 4ad09d956f8eacff61e67e5b13ba8ebec3232f76 (patch) | |
| tree | c63937494049202f21690bae7a82fd51feafecb5 /drivers/iio/industrialio-sw-trigger.c | |
| parent | 20690cd50e68c0313472c7539460168b8ea6444d (diff) | |
| download | lwn-4ad09d956f8eacff61e67e5b13ba8ebec3232f76.tar.gz lwn-4ad09d956f8eacff61e67e5b13ba8ebec3232f76.zip | |
iio: core: Fix entry not deleted when iio_register_sw_trigger_type() fails
In iio_register_sw_trigger_type(), configfs_register_default_group() is
possible to fail, but the entry add to iio_trigger_types_list is not
deleted.
This leaves wild in iio_trigger_types_list, which can cause page fault
when module is loading again. So fix this by list_del(&t->list) in error
path.
BUG: unable to handle page fault for address: fffffbfff81d7400
Call Trace:
<TASK>
iio_register_sw_trigger_type
do_one_initcall
do_init_module
load_module
...
Fixes: b662f809d410 ("iio: core: Introduce IIO software triggers")
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Link: https://lore.kernel.org/r/20221108032802.168623-1-chenzhongjin@huawei.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/industrialio-sw-trigger.c')
| -rw-r--r-- | drivers/iio/industrialio-sw-trigger.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/iio/industrialio-sw-trigger.c b/drivers/iio/industrialio-sw-trigger.c index 994f03a71520..d86a3305d9e8 100644 --- a/drivers/iio/industrialio-sw-trigger.c +++ b/drivers/iio/industrialio-sw-trigger.c @@ -58,8 +58,12 @@ int iio_register_sw_trigger_type(struct iio_sw_trigger_type *t) t->group = configfs_register_default_group(iio_triggers_group, t->name, &iio_trigger_type_group_type); - if (IS_ERR(t->group)) + if (IS_ERR(t->group)) { + mutex_lock(&iio_trigger_types_lock); + list_del(&t->list); + mutex_unlock(&iio_trigger_types_lock); ret = PTR_ERR(t->group); + } return ret; } |